Conversation
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
loloxwg
changed the title
KKould
approved these changes
Jul 5, 2023
Member
KKould
left a comment
KKould
left a comment
There was a problem hiding this comment.
i am fucking love it, merged now!
…rint it - add create table bind test - change logic of main function
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
loloxwg
added a commit
that referenced
this pull request
Jul 12, 2023
* refactor(catalog): refactor the implementation of Catalog and remove the two levels of Schema and DataBase for simplification * doc: delete wrong comment * feat: using a global nature id generator for ordered de duplication id generation to avoid third-party dependencies * fix(tests): ignore test_id_generator * feat(ci): Change toolchain. (#14) - Configure Gpt code review bot. * feat(binder): add create table binding (#16) * style(fmt): code format * feat(binder): add create table binding * feat(style): make code clean --------- Co-authored-by: Xwg <xuanwei.zhang@gatech.com> * feat(flow): execute the sql process to arrive at the logic plan and print it (#17) - add create table bind test - change logic of main function Co-authored-by: Xwg <xuanwei.zhang@gatech.com> * feat(catalog): 新增types mod以及catalog mod. - catalog 存储了库表列之间的关系结构 - types 类型系统表示了数据库字段的类型 * feat(catalog): 修改types接口模式，并实现在ColumnDesc 的new 方法中 - 更改函数签名中的&String到&str - 取消类型中的new方法，并将其归入ColumnDesc 的new 方法中统一实现 * feat(style): 修改文件命名方式，函数名称，提升可读性 * feat(catalog): 完成基本的catalog用来存储数据库元数据（库表名字段信息映射关系） * feat(binder): 完成create table binder - binder用来将解析后生成的 AST 和 Schema 信息绑定起来，检查输入的名称是否合法、是否有重复、有歧义 - catalog引入锁机制，创建column catalog流程改变 - 类型系统变化为sqlparser的DataTypeKind，并实现DataTypeExt trait，方便进行nullable设置 * fix(catalog): mutex 引入parking_lot，避免std库中的lock unwrap - 加入一些内联标志 * feat: executor graph. * fix cross meta-pipeline dependencies. * fix: all_pipeline miss. * refactor: pipeline event. --------- Co-authored-by: Kould <2435992353@qq.com> Co-authored-by: Xwg <xuanwei.zhang@gatech.edu> Co-authored-by: Xwg <xuanwei.zhang@gatech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer
check context logic of passing